View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 7: Move

    Please use a shorter topic

    Done

  • Patch Set #3, Line 9: legacying

    I'm not aware of mainboard specific gpio asl code. […]

    There are semantic changes to some of the macros defined in src/soc/intel/common/block/include/intelblocks/gpio_defs.h, notably PAD_CFG_GPI_APIC changes its number of arguments, and there are a handful of others macros that have changed.

    To remove that Kconfig symbol, the gpio.h for each board/variant needs to be picked through to replace any of the macros defined within #if CONFIG(SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS) in the above mentioned files, with the newer macros.

    Detailed instructions: https://docs.google.com/document/d/1X4Q5umA2tLxstdG6PkSMoEQCrTBXMZ_6KUqb-GkOdFs/edit?usp=sharing

To view, visit change 38207. To unsubscribe, or for help writing mail filters, visit settings.