Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 171:
(4 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/5b3e2ca7_5701b5dd PS171, Line 32: /* SIO init from PeiOemSioInit not necessary - only conditionally executed; not executed on system */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/a9b96c11_75cbcb1d PS171, Line 47: /* "MLID" in LGMR-based memory map is equivalent to "ELID" in EC-based memory map line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/ec.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/4f06b194_70fb6e36 PS171, Line 65: stopwatch_init_usecs_expire(&sw, 1000); // Vendor firmware gives 200 iterations of `Stall(5)` line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/a614b8a3_d7a374e7 PS171, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)