build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32075 )
Change subject: nb/intel/sandybridge: Introduce soc/iomap.h ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32075/2/src/northbridge/intel/sandybridge/ea... File src/northbridge/intel/sandybridge/early_init.c:
https://review.coreboot.org/#/c/32075/2/src/northbridge/intel/sandybridge/ea... PS2, Line 71: pci_write_config32(PCI_DEV(0, 0x00, 0), EPBAR + 4, EP_BASE_ADDRESS >> 32); line over 80 characters
https://review.coreboot.org/#/c/32075/2/src/northbridge/intel/sandybridge/ea... PS2, Line 73: pci_write_config32(PCI_DEV(0, 0x00, 0), MCHBAR + 4, MCH_BASE_ADDRESS >> 32); line over 80 characters
https://review.coreboot.org/#/c/32075/2/src/northbridge/intel/sandybridge/ea... PS2, Line 75: pci_write_config32(PCI_DEV(0, 0x00, 0), DMIBAR + 4, DMI_BASE_ADDRESS >> 32); line over 80 characters