[coreboot-gerrit] Change in coreboot[master]: security/tpm/crtm: Add a function to measure the bootblock on SoC level

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Christian Walter, Werner Zeh, Fred Reitberger, Andrey Petrov, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64492 )

Change subject: security/tpm/crtm: Add a function to measure the bootblock on SoC level
......................................................................

Patch Set 5:

(1 comment)

File src/soc/amd/common/block/cpu/noncar/bootblock_measure.c:

https://review.coreboot.org/c/coreboot/+/64492/comment/9268223c_6b40057b 
PS5, Line 5: int tspi_soc_measure_bootblock(int pcr_index)
           : {
           : 	return 1;
           : }
> I just followed the logic that is used in crtm.c. Here, if the measurement function 'tpm_measure_region()' returns with non-zero, this is treated as error. I think we should be consistent here.

Right. The question is whether doing nothing should be an error here. I'm just split, but I'm fine either way.