Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Christian Walter, Werner Zeh, Fred Reitberger, Andrey Petrov, Felix Held.

View Change

1 comment:

• File src/soc/amd/common/block/cpu/noncar/bootblock_measure.c:

  • Patch Set #5, Line 5:

    int tspi_soc_measure_bootblock(int pcr_index)
    {
    	return 1;
    }
    

    I just followed the logic that is used in crtm.c. Here, if the measurement function 'tpm_measure_region()' returns with non-zero, this is treated as error. I think we should be consistent here.

    Right. The question is whether doing nothing should be an error here. I'm just split, but I'm fine either way.

To view, visit change 64492. To unsubscribe, or for help writing mail filters, visit settings.