Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/google/dedede/var/boten: Update devicetree ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede... PS8, Line 42: [PchSerialIoIndexI2C5] = PchSerialIoPci, Is I2C5 used? If so, can you please add in the above table regarding the use-case for I2C5 and also enable the pci device corresponding to I2C5. Otherwise configure it as PchSerialIoDisabled.
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede... PS8, Line 52: Right Type-A Port How many USB-A and USB-C ports? This is overriding the Right Type-C port with Type-A port. Do you need to turn off the original Right Type-A port (ports 2.3 & 3.3)
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede... PS8, Line 83: 15 Nit: 0x15. Same for all the I2C addresses below for consistency.