View Change

3 comments:

• File src/mainboard/google/dedede/variants/boten/overridetree.cb:

  • Patch Set #8, Line 42: [PchSerialIoIndexI2C5] = PchSerialIoPci,

    Is I2C5 used? If so, can you please add in the above table regarding the use-case for I2C5 and also enable the pci device corresponding to I2C5. Otherwise configure it as PchSerialIoDisabled.

  • Patch Set #8, Line 52: Right Type-A Port

    How many USB-A and USB-C ports? This is overriding the Right Type-C port with Type-A port. Do you need to turn off the original Right Type-A port (ports 2.3 & 3.3)

  • Patch Set #8, Line 83: 15

    Nit: 0x15. Same for all the I2C addresses below for consistency.

To view, visit change 43175. To unsubscribe, or for help writing mail filters, visit settings.