Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48549 )
Change subject: mb/purism/librem_cnl: Use FMAP-based SPD cache
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48549/2/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/romstage.c:
https://review.coreboot.org/c/coreboot/+/48549/2/src/mainboard/purism/librem...
PS2, Line 104: cannonlake_memcfg_init(mem_cfg, &memcfg);
the SPD addressing is different when using coreboot to read the SPD via smbus vs FSP, so that alone […]
It would need to be thought. Anyway, no reason to block this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15cb9aa8b00d39d098a0f901aee026bac1161a80
Gerrit-Change-Number: 48549
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 19:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment