[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config

[Weimin Wu (Code Review)]

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, zhongtian wu.

Weimin Wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email )

Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
......................................................................

Patch Set 6:

(3 comments)

File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/83704/comment/afe28fb0_96321b9b?usp... :
PS5, Line 1: fw_config
           : 	field TOUCH 5
           : 		option TOUCH_ABSENT	0
           : 		option TOUCH_PRESENT	1
           : 	end
           : end
> Please move this to variants/baseboard/devicetree.cb along with other fw_config. […]

Done

File src/mainboard/google/dedede/variants/awasuki/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83704/comment/a5f9071d_506f4ee1?usp... :
PS5, Line 9: 	/* H4  : AP_I2C_TS_SDA */
           : 	PAD_NC(GPP_H4, NONE),
           : 	/* H5  : AP_I2C_TS_SCL */
           : 	PAD_NC(GPP_H5, NONE),
> Also you need to configure ENABLE, Reset and Stop/Report GPIOs as NC so that they are not floating o […]

Done

https://review.coreboot.org/c/coreboot/+/83704/comment/9aeb7032_ba580eae?usp... :
PS5, Line 24: 	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
            : 		cfg->SerialIoI2cMode[PchSerialIoIndexI2C2] = PchSerialIoDisabled;
            : 	}
            : 
            : 	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
            : 		printk(BIOS_INFO, "Disable TS GPIO pins.\n");
            : 		gpio_configure_pads(ts_disable_pad, ARRAY_SIZE(ts_disable_pad));
            : 	}
> Both the if blocks can be combined into one.

Done