Attention is currently required from: Eric Lai, Karthik Ramasubramanian, zhongtian wu.

View Change

3 comments:

• File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:

  • Patch Set #5, Line 1:

    fw_config
    	field TOUCH 5
    		option TOUCH_ABSENT	0
    		option TOUCH_PRESENT	1
    	end
    end
    

    Please move this to variants/baseboard/devicetree.cb along with other fw_config. […]

    Done

• File src/mainboard/google/dedede/variants/awasuki/ramstage.c:

  • Patch Set #5, Line 9:

    	/* H4  : AP_I2C_TS_SDA */
    	PAD_NC(GPP_H4, NONE),
    	/* H5  : AP_I2C_TS_SCL */
    	PAD_NC(GPP_H5, NONE),
    

    Also you need to configure ENABLE, Reset and Stop/Report GPIOs as NC so that they are not floating o […]

    Done

  • Patch Set #5, Line 24:

    	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
    		cfg->SerialIoI2cMode[PchSerialIoIndexI2C2] = PchSerialIoDisabled;
    	}
    
    	if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) {
    		printk(BIOS_INFO, "Disable TS GPIO pins.\n");
    		gpio_configure_pads(ts_disable_pad, ARRAY_SIZE(ts_disable_pad));
    	}
    

    Both the if blocks can be combined into one.

    Done

To view, visit change 83704. To unsubscribe, or for help writing mail filters, visit settings.