4 Jul
2019
4 Jul
'19
8:57 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210 ......................................................................
Patch Set 23:
(1 comment)
I think it's fine if you don't include the BLOB by default as the user will see the warning at the end of the build log.
https://review.coreboot.org/c/coreboot/+/32531/23/src/ec/51nb/npce985la0dx/K... File src/ec/51nb/npce985la0dx/Kconfig:
https://review.coreboot.org/c/coreboot/+/32531/23/src/ec/51nb/npce985la0dx/K... PS23, Line 29: default y the default should be n as the EC firmware is not part of the repository
--
To view, visit https://review.coreboot.org/c/coreboot/+/32531
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74621e76d703f629b54f1feb1acfc95cc72d183
Gerrit-Change-Number: 32531
Gerrit-PatchSet: 23
Gerrit-Owner: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 04 Jul 2019 06:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment