Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210
......................................................................
Patch Set 28:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/Kc...
File src/mainboard/51nb/x210/Kconfig:
https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/Kc...
PS28, Line 12: select MAINBOARD_USES_FSP2_0
Not needed, since this is selected by the SOC
https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/Kc...
PS28, Line 16: config MAINBOARD_VENDOR
: string
: default "51NB"
Not needed, since it is set by `src/mainboard/51nb/Kconfig`
https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/Kc...
PS28, Line 36: config DEVICETREE
: string
: default "devicetree.cb"
Not needed, since this is the default name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74621e76d703f629b54f1feb1acfc95cc72d183
Gerrit-Change-Number: 32531
Gerrit-PatchSet: 28
Gerrit-Owner: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Sep 2019 21:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment