Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )
Change subject: Add support for the 51nb X210 ......................................................................
Patch Set 24: Code-Review+1
(3 comments)
Looks pretty good.
https://review.coreboot.org/c/coreboot/+/32531/24/Documentation/mainboard/51... File Documentation/mainboard/51nb/x210.md:
https://review.coreboot.org/c/coreboot/+/32531/24/Documentation/mainboard/51... PS24, Line 13: # I would suggest explaining how to flash internally using a layout/fmap, for images built without EC firmware. With that, one just needs to build coreboot without IFD/ME/GBE/EC blobs (just FSP and VBIOS, I think? probably worth explaining as well), then flash coreboot to the fmap space for it (fmap region called COREBOOT?) without overwriting what is already on the flash chip.
https://review.coreboot.org/c/coreboot/+/32531/23/src/ec/51nb/npce985la0dx/K... File src/ec/51nb/npce985la0dx/Kconfig:
https://review.coreboot.org/c/coreboot/+/32531/23/src/ec/51nb/npce985la0dx/K... PS23, Line 27: images Minor: there's just one image, so this should be singular
https://review.coreboot.org/c/coreboot/+/32531/23/src/ec/51nb/npce985la0dx/K... PS23, Line 29: default y
Ack
Since you're using a fmap in coreboot, you can use it with flashrom to flash only to the FMAP's BIOS region, without overwriting the EC firmware. AFAIUI, it should work after the initial flash (and for the initial flash, I'd just use a layout).
However, having the option doesn't hurt.