Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass ......................................................................
Patch Set 14:
(5 comments)
Thanks for the review. I have changes ready but not able to send right now. The current tip is broken for my compiler, the change identified is not committed yet.
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 34: OCP
Vendor shouldn't be needed here
Why not?
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 34: TiogaPass
Is it TiogaPass or Tioga Pass?
Will use TiogaPass consistently.
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 39: : config MAINBOARD_VENDOR : string : default "OCP"
Set to "Open Compute Project" in src/mb/ocp/Kconfig
Done
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 25: CPPFLAGS_common += -I$(src)/soc/intel/skylake_sp/include
This should not be here
Done
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 62: device pci 04.0 on end # Intel Corporation Sky Lake-E CBDMA Registers
These comments can be shortened
Done