Thanks for the review. I have changes ready but not able to send right now. The current tip is broken for my compiler, the change identified is not committed yet.
5 comments:
File src/mainboard/ocp/tiogapass/Kconfig:
Vendor shouldn't be needed here
Why not?
Patch Set #14, Line 34: TiogaPass
Is it TiogaPass or Tioga Pass?
Will use TiogaPass consistently.
config MAINBOARD_VENDOR
string
default "OCP"
Set to "Open Compute Project" in src/mb/ocp/Kconfig
Done
File src/mainboard/ocp/tiogapass/Makefile.inc:
Patch Set #14, Line 25: CPPFLAGS_common += -I$(src)/soc/intel/skylake_sp/include
This should not be here
Done
File src/mainboard/ocp/tiogapass/devicetree.cb:
Patch Set #14, Line 62: device pci 04.0 on end # Intel Corporation Sky Lake-E CBDMA Registers
These comments can be shortened
Done
To view, visit change 38549. To unsubscribe, or for help writing mail filters, visit settings.