Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43442 )
Change subject: mb/google/volteer: Add new variant Lingcod ......................................................................
Patch Set 10:
(7 comments)
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/lingcod/gpio.c:
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 51: /* C22 : UART2_RTS# ==> PCH_FPMCU_BOOT0 */ : PAD_CFG_GPO(GPP_C22, 0, DEEP), : /* C23 : UART2_CTS# ==> FPMCU_RST_ODL */ : PAD_CFG_GPO(GPP_C23, 1, DEEP), Could you please double check if you need to support the fingerprint? I don' find the fingerprint from the schematics.
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 62: /* D17 : ISH_GP4 ==> EN_CVF_PWR */ : PAD_CFG_GPO(GPP_D17, 1, DEEP), Do you need this? From the schematics, the PP3300_FCAM doesn't connect to anything. Please double check it.
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 65: /* E1 : SPI1_IO2 ==> PEN_DET_ODL */ : PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE), Will the project support the pen ejection? I don't see the implementation from the schematics.
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 77: /* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */ : PAD_CFG_GPI(GPP_E12, NONE, DEEP), Please check if this is needed. I don't see the pen charger.
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 97: /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */ : PAD_CFG_GPI(GPP_H19, NONE, DEEP), Could you please double check if you need to support the fingerprint?
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 153: /* C22 : UART2_RTS# ==> PCH_FPMCU_BOOT0 */ : PAD_CFG_GPO(GPP_C22, 0, DEEP), : Could you please double check if you need to support the fingerprint?
https://review.coreboot.org/c/coreboot/+/43442/10/src/mainboard/google/volte... PS10, Line 156: /* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */ : PAD_CFG_GPO(GPP_E12, 1, DEEP), Please check if this is needed. I don't see the pen charger.