build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46657 )
Change subject: soc/intel/xeon_sp: Add a smm_region function ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/cpx/i... File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/cpx/i... PS2, Line 85: #define VTD_DEV(bus) pcidev_path_on_bus((bus), PCIDEV_FN(VTD_DEV_NUM, VTD_FUNC_NUM) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/cpx/i... PS2, Line 91: #define VTD_DEV(bus) pcidev_path_on_bus((bus), PCIDEV_FN(VTD_DEV_NUM, VTD_FUNC_NUM) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/skx/i... File src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/skx/i... PS2, Line 134: #define VTD_DEV(bus) pcidev_path_on_bus((bus), PCIDEV_FN(VTD_DEV_NUM, VTD_FUNC_NUM) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46657/2/src/soc/intel/xeon_sp/skx/i... PS2, Line 140: #define VTD_DEV(bus) pcidev_path_on_bus((bus), PCIDEV_FN(VTD_DEV_NUM, VTD_FUNC_NUM) Macros with complex values should be enclosed in parentheses