Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: Adding Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M. ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/#/c/30987/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30987/2//COMMIT_MSG@7 PS2, Line 7: Adding Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M. Please use imperative mode for the verbs in the commit message: "Add Asus A88XM-E FM2+..."
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... File Documentation/mainboard/asus/a88xm-e.md:
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 59: trailing space
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 83: - Integrated ethernet Maybe it is missing a MAC address? coreboot has a driver for that.
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 87: trailing space
https://review.coreboot.org/#/c/30987/2/Documentation/mainboard/asus/a88xm-e... PS2, Line 88: board with factory image makes it work again as fallback. This is probably because the xHCI blob is loaded by the vendor BIOS onto the controllers, which coreboot should do. Does booting the vendor BIOS, flashing coreboot internally, powering off the board completely and then booting coreboot result in usable xHCI ports?
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig@2... PS2, Line 29: SUPERIO_ITE_IT8728F This works with the ITE IT8603?
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/Kconfig@1... PS2, Line 113: config DEVICETREE : string : default "devicetree_a88xm-e.cb" Rename the devicetree to "devicetree.cb" and drop this.
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/board_inf... File src/mainboard/asus/a88xm-e/board_info.txt:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/board_inf... PS2, Line 4: [http://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash... SPI] There is no need to link anything here. Just "SPI" is enough.
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/romstage.... File src/mainboard/asus/a88xm-e/romstage.c:
https://review.coreboot.org/#/c/30987/2/src/mainboard/asus/a88xm-e/romstage.... PS2, Line 49: pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1); : pnp_devfn_t gpio = PNP_DEV(0x2e, IT8728F_GPIO); These can be macros