build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation
......................................................................
Patch Set 4:
(235 comments)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
File src/mainboard/asus/a88xm-e/BiosCallOuts.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 24: {
that open brace { should be on the previous line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 79: {
that open brace { should be on the previous line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 80: {0x10ec0887, (CODEC_ENTRY*)&a88xm_e_alc887_VerbTbl[0]},
"(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 81: {(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL}
"(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 84: void board_FCH_InitReset(struct sysinfo *cb_NA, FCH_RESET_DATA_BLOCK
*FchParams_reset)
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 92: FchParams_env->Azalia.AzaliaOemCodecTablePtr = (CODEC_TBL_LIST
*)(&CodecTableList[0]);
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/BiosCall…
PS4, Line 97: FchParams_env->Hwm.HwmFchtsiAutoPoll = FALSE;/* 1 enable, 0 disable TSI
Auto Polling */
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 78: /* PCIe port, Lanes 4:7, PCI Device Number 4, black x16 slot (in fact x4)
*/
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 117: PCIE_DDI_DATA_INITIALIZER(ConnectorTypeNutmegDpToVga, Aux2, Hdp2)
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 147:
/*----------------------------------------------------------------------------------------
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 149:
*----------------------------------------------------------------------------------------
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 153: * Platform Specific Overriding Table allows IBV/OEM to pass in platform
information to AGESA
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 154: * (e.g. MemClk routing, the number of DIMM slots per channel,...). If
PlatformSpecificTable
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 155: * is populated, AGESA will base its settings on the data from the table.
Otherwise, it will
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 161: NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, 1),
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 162: NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 2),
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 164: PSO_END
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/OemCusto…
PS4, Line 170: InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)
MemoryTable_XM_E;
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/acpi_tab…
File src/mainboard/asus/a88xm-e/acpi_tables.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/acpi_tab…
PS4, Line 29: current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *) current,
CONFIG_MAX_CPUS,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/acpi_tab…
PS4, Line 42: current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current,
0xff, 5, 1);
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 142: #define BLDCFG_PCIE_REFCLK_SPREAD_SPECTRUM 36 // PCIE Spread
Spectrum default value 0.36%
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 158: //#define BLDCFG_VRM_NB_CURRENT_LIMIT 0 // Not currently
used on Trinity
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 159: //#define BLDCFG_VRM_NB_LOW_POWER_THRESHOLD 1 // Zero - disable
NBPSI_L, Non-zero - enable NBPSI_L
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 160: //#define BLDCFG_VRM_NB_SLEW_RATE 5000 // Used in
calculating the VSRampSlamTime
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 161: //#define BLDCFG_VRM_NB_ADDITIONAL_DELAY 0 // Not currently
used on Trinity
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 162: //#define BLDCFG_VRM_NB_HIGH_SPEED_ENABLE 0 // Not currently
used on Trinity
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 163: //#define BLDCFG_VRM_NB_INRUSH_CURRENT_LIMIT 0 // Not currently
used on Trinity
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 173: //#define BLDCFG_UMA_ALLOCATION_SIZE 0x1000//0x1800//0x1000 /* (1000
<< 16) = 256M*/
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 173: //#define BLDCFG_UMA_ALLOCATION_SIZE 0x1000//0x1800//0x1000 /* (1000
<< 16) = 256M*/
please, no space before tabs
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 174: #define BLDCFG_UMA_ALLOCATION_SIZE 0x2000//512M
please, no space before tabs
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 230: {
that open brace { should be on the previous line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 231: { AMD_AP_MTRR_FIX64k_00000, 0x1E1E1E1E1E1E1E1E },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 232: { AMD_AP_MTRR_FIX16k_80000, 0x1E1E1E1E1E1E1E1E },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 233: { AMD_AP_MTRR_FIX16k_A0000, 0x0000000000000000 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 234: { AMD_AP_MTRR_FIX4k_C0000, 0x0000000000000000 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 235: { AMD_AP_MTRR_FIX4k_C8000, 0x0000000000000000 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 236: { AMD_AP_MTRR_FIX4k_D0000, 0x0000000000000000 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 237: { AMD_AP_MTRR_FIX4k_D8000, 0x0000000000000000 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 238: { AMD_AP_MTRR_FIX4k_E0000, 0x1818181818181818 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 239: { AMD_AP_MTRR_FIX4k_E8000, 0x1818181818181818 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 240: { AMD_AP_MTRR_FIX4k_F0000, 0x1818181818181818 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 241: { AMD_AP_MTRR_FIX4k_F8000, 0x1818181818181818 },
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 242: { CPU_LIST_TERMINAL }
please, no spaces at the start of a line
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 245: #define BLDCFG_AP_MTRR_SETTINGS_LIST &TrinityApMtrrSettingsList
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 247: // This is the delivery package title,
"BrazosPI"
code indent should use tabs where possible
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 248: // This string MUST be exactly 8 characters long
code indent should use tabs where possible
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 251: // This is the release version number of the AGESA
component
code indent should use tabs where possible
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 252: // This string MUST be exactly 12 characters long
code indent should use tabs where possible
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 253: #define AGESA_VERSION_STRING {'V', '0', '.',
'0', '.', '0', '.', '1', ' ', ' ',
' ', ' '}
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 267: #define UNSUPPORTED_DDR_FREQUENCY 1201 ///< Highest limit of DDR
frequency
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 270: #define QUADRANK_REGISTERED 0 ///< Quadrank registered DIMM
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 271: #define QUADRANK_UNBUFFERED 1 ///< Quadrank unbuffered DIMM
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 274: #define TIMING_MODE_AUTO 0 ///< Use best rate possible
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 275: #define TIMING_MODE_LIMITED 1 ///< Set user top limit
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 280: #define POWER_DOWN_BY_CHIP_SELECT 1 ///< Chip select power down mode
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 334: // The following definitions specify the default values for various
parameters in which there are
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/buildOpt…
PS4, Line 335: // no clearly defined defaults to be used in the common file. The values
below are based on product
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/irq_tabl…
File src/mainboard/asus/a88xm-e/irq_tables.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/irq_tabl…
PS4, Line 94: if (sum != pirq->checksum) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/irq_tabl…
PS4, Line 98: printk(BIOS_INFO, "write_pirq_routing_table done.\n");
Prefer using '"%s...", __func__' to using
'write_pirq_routing_table', this function's name, in a string
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mainboar…
File src/mainboard/asus/a88xm-e/mainboard.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mainboar…
PS4, Line 28: printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER
" Enable.\n");
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.c
File src/mainboard/asus/a88xm-e/mptable.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 26:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 27:
0x09,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 28:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 29:
0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 30:
0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 31: 0x1F,0x1F,0x1F,0x1F
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 34:
0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 35:
0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 36:
0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 37:
0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 38:
0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 39: 0x10,0x11,0x12,0x13
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 42: static void smp_add_mpc_entry(struct mp_config_table *mc, unsigned length)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 91: for (byte = 0x0; byte < sizeof(picr_data); byte ++) {
space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 97: for (byte = 0x0; byte < sizeof(intr_data); byte ++) {
space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 102: /* I/O Ints: Type Polarity Trigger Bus ID IRQ APIC ID
PIN# */
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 103: #define IO_LOCAL_INT(type, intr, apicid, pin) \
macros should not use a trailing semicolon
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH,
bus_isa, (intr), (apicid), (pin));
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 111: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW,
(bus), (((dev)<<2)|(int_sign)), ioapic_id, (pin))
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/mptable.…
PS4, Line 167: /*Local Ints: Type Polarity Trigger Bus ID IRQ APIC ID
PIN# */
line over 80 characters
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/romstage…
File src/mainboard/asus/a88xm-e/romstage.c:
https://review.coreboot.org/#/c/30987/4/src/mainboard/asus/a88xm-e/romstage…
PS4, Line 31: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 +
(x))
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 4
Gerrit-Owner: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: mikeb mikeb <mikebdp2(a)gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 18:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment