View Change

9 comments:

• Commit Message:

  • Patch Set #2, Line 7: Adding Asus A88XM-E FM2+ motherboard with documentation, the port based on F2A85-M.

    Please use imperative mode for the verbs in the commit message: "Add Asus A88XM-E FM2+..."

• File Documentation/mainboard/asus/a88xm-e.md:

  • Patch Set #2, Line 59:

    trailing space

  • Patch Set #2, Line 83: - Integrated ethernet

    Maybe it is missing a MAC address? coreboot has a driver for that.

  • Patch Set #2, Line 87:

    trailing space

  • Patch Set #2, Line 88: board with factory image makes it work again as fallback.

    This is probably because the xHCI blob is loaded by the vendor BIOS onto the controllers, which coreboot should do. Does booting the vendor BIOS, flashing coreboot internally, powering off the board completely and then booting coreboot result in usable xHCI ports?

• File src/mainboard/asus/a88xm-e/Kconfig:

  • Patch Set #2, Line 29: SUPERIO_ITE_IT8728F

    This works with the ITE IT8603?

  • Patch Set #2, Line 113:

    config DEVICETREE
    	string
    	default "devicetree_a88xm-e.cb"
    

    Rename the devicetree to "devicetree.cb" and drop this.

• File src/mainboard/asus/a88xm-e/board_info.txt:

  • Patch Set #2, Line 4: [http://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&partNo=W25Q64FV SPI]

    There is no need to link anything here. Just "SPI" is enough.

• File src/mainboard/asus/a88xm-e/romstage.c:

  • Patch Set #2, Line 49:

    	pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1);
    	pnp_devfn_t gpio = PNP_DEV(0x2e, IT8728F_GPIO);
    

    These can be macros

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.