Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36836 )
Change subject: Make firmware update hardware version aware ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/em100/+/36836/1/firmware.c File firmware.c:
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@203 PS1, Line 203: 4
should we name them? or only once there are three of them?
HW_VERSION_4? I considered that, but I didn't feel that was going to be helpful. Particularly since I don't know at this point if there are non-4 EM100Pro or non-6 EM100Pro-G2s out there (and I never saw an EM100 non PRO)
https://review.coreboot.org/c/em100/+/36836/1/firmware.c@243 PS1, Line 243: em100->hwversion == 4
It's still potentially an EM100Pro firmware file, so the error message would be confusing, no? […]
I have a followon patch in the queue. I think I'll change the message to EM100Pro (non-G2) or EM100Pro (G1).
The other files will be referred to as EM100Pro-G2 firmware files.