View Change
2 comments:
File firmware.c:
Patch Set #1, Line 203: 4
should we name them? or only once there are three of them?
HW_VERSION_4? I considered that, but I didn't feel that was going to be helpful. Particularly since I don't know at this point if there are non-4 EM100Pro or non-6 EM100Pro-G2s out there (and I never saw an EM100 non PRO)
Patch Set #1, Line 243: em100->hwversion == 4
It's still potentially an EM100Pro firmware file, so the error message would be confusing, no? […]
I have a followon patch in the queue. I think I'll change the message to EM100Pro (non-G2) or EM100Pro (G1).
The other files will be referred to as EM100Pro-G2 firmware files.
To view, visit change 36836. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ia284adca4cb4d341a8d229374b6ea0b5d2a5d5c0
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 14 Nov 2019 20:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: comment