Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34805 )
Change subject: arch/x86: Add postcar_frame_add_top_of_ram_cache() API ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34805/2/src/arch/x86/include/arch/c... File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/34805/2/src/arch/x86/include/arch/c... PS2, Line 334: cache This isn't a cache, though. What's your reasoning for choosing 'cache' in the name? I also think the comment could be more descriptive as it's more than what is listed.
https://review.coreboot.org/c/coreboot/+/34805/2/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/34805/2/src/arch/x86/postcar_loader... PS2, Line 135: MTRR_TYPE_WRPROT This type is inherently wrong as you'll be writing to this memory for loading purposes. All that it does it ensure writes don't hit the cache.