2 comments:
File src/arch/x86/include/arch/cpu.h:
Patch Set #2, Line 334: cache
This isn't a cache, though. What's your reasoning for choosing 'cache' in the name? I also think the comment could be more descriptive as it's more than what is listed.
File src/arch/x86/postcar_loader.c:
Patch Set #2, Line 135: MTRR_TYPE_WRPROT
This type is inherently wrong as you'll be writing to this memory for loading purposes. All that it does it ensure writes don't hit the cache.
To view, visit change 34805. To unsubscribe, or for help writing mail filters, visit settings.