Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44232 )
Change subject: cpu/x86: Introduce `CPU_X86_TSC`
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
This sort of duplicates an existing Kconfig option
https://review.coreboot.org/c/coreboot/+/44232/3/src/cpu/x86/Kconfig
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/44232/3/src/cpu/x86/Kconfig@17
PS3, Line 17: CPU_X86_TSC
The code is only included if UDELAY_TSC is you now need UDELAY_TSC and this new one to actually use the code. Maybe just include the code if UDELAY_TSC is set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7d8229d23b3fa515e56f4a4541b246ac7a6fbc1
Gerrit-Change-Number: 44232
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Aug 2020 23:33:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment