chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45333 )
Change subject: soc/amd/picasso: Add UPD for support force USB3 to Gen1 by port
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45333/7/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/7/src/soc/amd/picasso/chip.h@...
PS7, Line 173: uint8_t xhci0_force_gen1;
+1 some documentation here would be helpful.
Add comment for xhci0_force_gen1 and usb3_port_froce_gen1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896c185988c3ea5dbdd72957b363ebdaa2747cff
Gerrit-Change-Number: 45333
Gerrit-PatchSet: 8
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 25 Sep 2020 13:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment