Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44014 )
Change subject: src/soc/intel/common: Make top_of_ram till TOLUD region mmio_resource
......................................................................
Patch Set 9: Code-Review+2
Patch Set 9:
Patch Set 9: Code-Review+1
Patch Set 9: Code-Review+1
Let's see what others have to say.
I'm still not sure *why* we should change this (or why we should keep the current setup).
Angel, the point of making this change would be, we don't need to make those ranges mark cacheable specifically reserve HW range for OS to consume as coreboot has done TSEG/SMM relocation hence benefit has already before, anything we are marking here is for OS usage or telling OS then do we see any need to say those ranges are cacaheable either rather this CL make those HW reserve range just IO_RESERVE.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64c14b14caf0a53219fdc02ec6bbd375955a0c8e
Gerrit-Change-Number: 44014
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 07:10:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment