Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/...
PS2, Line 88: GPP_D16_IRQ
Probably need to configure GPP_D16 in kohaku overridetree.cb with INVERT for PAD_CFG_GPI_APIC.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08
Gerrit-Change-Number: 34763
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 17:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment