Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
mb/google/hatch: Kohaku: Add touchscreen controller to device tree
The touchscreen controller was never added to the device tree, and the next board rev will have this IC connected. Set it up in the device tree with conservative power resource timings from the datasheet.
BUG=b:138869702 BRANCH=none TEST=compiles; current board rev does not have touch IC
Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34763/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index b3ae1bc..2bbb72d 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -81,6 +81,19 @@ end end # I2C 0
+ device pci 15.1 on + chip drivers/i2c/generic + register "hid" = ""ATML0001"" + register "desc" = ""Atmel Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "10" + register "has_power_resource" = "1" + register "disable_gpio_export_in_crs" = "1" + device i2c 4b on end + end + end # I2C #1 + device pci 15.2 on chip drivers/i2c/hid register "generic.hid" = ""WCOM50C1""
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... PS1, Line 90: register "reset_delay_ms" = "10" Don't you also need the enable_gpio to ensure that power gets enabled for the device?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... PS1, Line 90: register "reset_delay_ms" = "10"
Don't you also need the enable_gpio to ensure that power gets enabled for the device?
The only "enable" signal I see is TOUCHSCREEN_DIS_L which looks to be an active-low disable, but it's tied to PP3300_TSP_DX.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... PS1, Line 90: register "reset_delay_ms" = "10"
The only "enable" signal I see is TOUCHSCREEN_DIS_L which looks to be an active-low disable, but it' […]
and the TSP_DX is gated by EN_PP3300_TSP_DIG_DX, for which the 0ohm resistor is nostuff.
Hello Paul Fagerburg, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34763
to look at the new patch set (#2).
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
mb/google/hatch: Kohaku: Add touchscreen controller to device tree
The touchscreen controller was never added to the device tree, and the next board rev will have this IC connected. Set it up in the device tree with conservative power resource timings from the datasheet.
BUG=b:138869702 BRANCH=none TEST=compiles; current board rev does not have touch IC
Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34763/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/... PS1, Line 90: register "reset_delay_ms" = "10"
and the TSP_DX is gated by EN_PP3300_TSP_DIG_DX, for which the 0ohm resistor is nostuff.
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 2: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/... PS2, Line 88: GPP_D16_IRQ Probably need to configure GPP_D16 in kohaku overridetree.cb with INVERT for PAD_CFG_GPI_APIC.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/2/src/mainboard/google/hatch/... PS2, Line 88: GPP_D16_IRQ
Probably need to configure GPP_D16 in kohaku overridetree.cb with INVERT for PAD_CFG_GPI_APIC.
Ack
Hello Paul Fagerburg, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34763
to look at the new patch set (#3).
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
mb/google/hatch: Kohaku: Add touchscreen controller to device tree
The touchscreen controller was never added to the device tree, and the next board rev will have this IC connected. Set it up in the device tree with conservative power resource timings from the datasheet.
BUG=b:138869702 BRANCH=none TEST=compiles; current board rev does not have touch IC
Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/34763/3
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 3: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
Patch Set 3: Code-Review+2
Shelley Chen has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree ......................................................................
mb/google/hatch: Kohaku: Add touchscreen controller to device tree
The touchscreen controller was never added to the device tree, and the next board rev will have this IC connected. Set it up in the device tree with conservative power resource timings from the datasheet.
BUG=b:138869702 BRANCH=none TEST=compiles; current board rev does not have touch IC
Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34763 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 19 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index d22de04..bc9df38 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -41,10 +41,14 @@ PAD_NC(GPP_C1, NONE), /* C7 : PEN_IRQ_OD_L */ PAD_CFG_GPI_APIC(GPP_C7, NONE, PLTRST, LEVEL, INVERT), + /* C12 : EN_PP3300_TSP_DX */ + PAD_CFG_GPO(GPP_C12, 0, DEEP), /* C15 : EN_PP3300_DIG_DX */ PAD_CFG_GPO(GPP_C15, 0, DEEP), /* C23 : UART2_CTS# ==> NC */ PAD_NC(GPP_C23, NONE), + /* D16 : TOUCHSCREEN_INT_L */ + PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT), /* E23 : GPP_E23 ==> NC */ PAD_NC(GPP_E23, NONE), /* F1 : GPP_F1 ==> NC */ diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 8a1de84..57429ad 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -81,6 +81,21 @@ end end # I2C 0
+ device pci 15.1 on + chip drivers/i2c/generic + register "hid" = ""ATML0001"" + register "desc" = ""Atmel Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "91" # 90.5 ms + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C12)" + register "enable_delay_ms" = "1" # 90 ns + register "has_power_resource" = "1" + register "disable_gpio_export_in_crs" = "1" + device i2c 4b on end + end + end # I2C #1 + device pci 15.2 on chip drivers/i2c/hid register "generic.hid" = ""WCOM50C1""