Attention is currently required from: Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard/asus/p8x7x-series: Add new variant P8Z77-M ......................................................................
Patch Set 18:
(9 comments)
This change is ready for review.
Patchset:
PS18:
After https://review.coreboot. […]
Yep. This is the plan. Update to follow.
File src/mainboard/asus/p8z77-m/cmos.default:
https://review.coreboot.org/c/coreboot/+/38988/comment/33ec9c1e_a823a364 PS18, Line 6: Enable
I'd disable NMIs by default.
Done
File src/mainboard/asus/p8z77-m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38988/comment/380657ef_c82da04b PS18, Line 6: register "c1_acpower" = "1" : register "c1_battery" = "1" : register "c2_acpower" = "3" : register "c2_battery" = "3" : register "c3_acpower" = "5" : register "c3_battery" = "5"
These were deduplicated and changed to `acpi_cX`
Ack
File src/mainboard/asus/p8z77-m/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38988/comment/f11fd951_625b7741 PS18, Line 7: 0x02, /* DSDT revision: ACPI 2.0 and up */
ACPI_DSDT_REV_2
Done
File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/comment/0549c5bb_162462cc PS18, Line 69: static const u8 register_values[] = {
Do all of these values need to be programmed so early? If not, I'd program them through the devicetr […]
I was able to move all to devicetree without immediate issues.
https://review.coreboot.org/c/coreboot/+/38988/comment/66f7f295_d0109daa PS18, Line 187: int usb3_mode = 1; : get_option(&usb3_mode, "usb3_mode");
I've changed the option API, this should now be: […]
Done
https://review.coreboot.org/c/coreboot/+/38988/comment/cf9cd4ce_3de6eb25 PS18, Line 201: pei->system_type = 1; /* 0=Mobile, 1=Desktop/Server */
Should already be set automatically by chipset code.
Done
https://review.coreboot.org/c/coreboot/+/38988/comment/59075617_3ef56902 PS18, Line 203: 4
sizeof(spdaddr)
Done
https://review.coreboot.org/c/coreboot/+/38988/comment/32c0f22b_5abcd1cd PS18, Line 209: ARRAY_SIZE
This should be `sizeof`
Done