Attention is currently required from: Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons.
9 comments:
Patchset:
After https://review.coreboot. […]
Yep. This is the plan. Update to follow.
File src/mainboard/asus/p8z77-m/cmos.default:
Patch Set #18, Line 6: Enable
I'd disable NMIs by default.
Done
File src/mainboard/asus/p8z77-m/devicetree.cb:
register "c1_acpower" = "1"
register "c1_battery" = "1"
register "c2_acpower" = "3"
register "c2_battery" = "3"
register "c3_acpower" = "5"
register "c3_battery" = "5"
These were deduplicated and changed to `acpi_cX`
Ack
File src/mainboard/asus/p8z77-m/dsdt.asl:
Patch Set #18, Line 7: 0x02, /* DSDT revision: ACPI 2.0 and up */
ACPI_DSDT_REV_2
Done
File src/mainboard/asus/p8z77-m/early_init.c:
Patch Set #18, Line 69: static const u8 register_values[] = {
Do all of these values need to be programmed so early? If not, I'd program them through the devicetr […]
I was able to move all to devicetree without immediate issues.
int usb3_mode = 1;
get_option(&usb3_mode, "usb3_mode");
I've changed the option API, this should now be: […]
Done
Patch Set #18, Line 201: pei->system_type = 1; /* 0=Mobile, 1=Desktop/Server */
Should already be set automatically by chipset code.
Done
sizeof(spdaddr)
Done
Patch Set #18, Line 209: ARRAY_SIZE
This should be `sizeof`
Done
To view, visit change 38988. To unsubscribe, or for help writing mail filters, visit settings.