chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45333 )
Change subject: soc/amd/picasso: Add UPD for support force USB3 to Gen1 by port ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/picasso: Add Upd for support force USB3 to Gen1 by port
Note that `UPD` should be spelled in uppercase
Done
https://review.coreboot.org/c/coreboot/+/45333/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/1/src/soc/amd/picasso/chip.h@... PS1, Line 171: uint32_t usb3_port_force_gen1;
Keep the blank line before the comment?
Done
https://review.coreboot.org/c/coreboot/+/45333/1/src/soc/amd/picasso/chip.h@... PS1, Line 171: uint32_t
The FSP UPD seems to be an uint8_t, so this should be uint8_t as well.
Done