Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35656 )
Change subject: [WIP] soc/intel: Replace config_of_path() with config_of_soc() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35656/1/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/35656/1/src/include/device/device.h... PS1, Line 317: static inline DEVTREE_CONST void *config_of_soc(void) : { : return config_of(pcidev_on_root(0, 0)); : } Overall the change looks good to me. I am just wondering if this function should be put under soc/intel/common since: 1. config_of_path()/config_of_soc() is used by only soc/intel/... and mainboards using those SoCs 2. pcidev_on_root(0, 0) for getting to this config is kind of true for only soc/intel/... It doesn't seem to be true for boards with northbridge/southbridge for example.