1 comment:
File src/include/device/device.h:
static inline DEVTREE_CONST void *config_of_soc(void)
{
return config_of(pcidev_on_root(0, 0));
}
Overall the change looks good to me. I am just wondering if this function should be put under soc/intel/common since:
1. config_of_path()/config_of_soc() is used by only soc/intel/... and mainboards using those SoCs
2. pcidev_on_root(0, 0) for getting to this config is kind of true for only soc/intel/... It doesn't seem to be true for boards with northbridge/southbridge for example.
To view, visit change 35656. To unsubscribe, or for help writing mail filters, visit settings.