Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44102 )
Change subject: [WIP]mb/intel/minnowmax: Add mainboard ......................................................................
Patch Set 3:
(6 comments)
Made a couple more comments. It's working fine on my Minnowboard with the changes mentioned below.
https://review.coreboot.org/c/coreboot/+/44102/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44102/3//COMMIT_MSG@25 PS3, Line 25: - SD card
SD card does not work. Getting "Unexpected interrupt 0x4000000. […]
Setting the sdcard_cap_low and sdcard_cap_high in the devicetree.cb fixes this issue.
https://review.coreboot.org/c/coreboot/+/44102/3//COMMIT_MSG@26 PS3, Line 26: - Display output Works fine with VBIOS.
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/cmos.layout:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 18: 409 2 e 7 power_on_after_fail Would it make more sense to have it 1 since the device has no power button?
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 27: The SD card won't work unless you add the following (from the rambi devicetree.cb): register "sdcard_cap_low" = "0x036864b2" register "sdcard_cap_high" = "0x0"
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 52: device pci 1a.0 on end # 8086 0F18 - TXE - This device isn't supported, might as well disable it to spare some dmesg errors.
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/spd/micron_2GiB_dimm_MT41K256M16HA-125.spd.hex:
https://review.coreboot.org/c/coreboot/+/44102/3/src/mainboard/intel/minnowm... PS3, Line 33: If this SPD was chosen at random it's an odd coincidence that it is the exact chips that are on my Minnowmax.