Attention is currently required from: David Hendricks, Evgeny Zinoviev, Felix Singer, Martin L Roth, Paul Menzel.
Angel Pons has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 57:
(6 comments)
File Documentation/mainboard/apple/mbp101_board.jpg:
PS57: You should not be executable
File src/mainboard/apple/macbookpro10_1/cmos.default:
PS57: Add license header as per commit e623845df64b28d2c809e40c0703d18d6bc246c4
File src/mainboard/apple/macbookpro10_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32673/comment/43342b71_7e102085?usp... : PS57, Line 6: device ref peg10 on end : device ref peg12 on end : device ref peg11 on end nit: order
```suggestion device ref peg10 on end device ref peg11 on end device ref peg12 on end ```
https://review.coreboot.org/c/coreboot/+/32673/comment/13841415_2f5b92b1?usp... : PS57, Line 29: register "spi_lvscc" = "0x0" Isn't this the default?
https://review.coreboot.org/c/coreboot/+/32673/comment/f72ef424_14d25fa9?usp... : PS57, Line 35: device ref mei1 on end Isn't MEI1 enabled by default?
File src/mainboard/apple/macbookpro10_1/spd/2g_hynix_1600.spd.hex:
PS52:
I recall that pure data is not licensable.
https://github.com/coreboot/coreboot/blob/940fe080bf1ed2dac827b569c70fb0ea11... does not use a license header.