[coreboot-gerrit] Change in coreboot[master]: soc/intel: Use config_of_path(SA_DEVFN_ROOT)

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34299 )

Change subject: soc/intel: Use config_of_path(SA_DEVFN_ROOT)
......................................................................

Patch Set 4:
> Hi Kyösti, yes scan-build actually runs daily, you can see the results here if you like [0]. Making the function __noreturn should be enough to convince it that config_of() will never return with NULL. It's also probably a good thing to remove the extra checks that Furquan has pointed out, since otherwise Coverity will flag them as dead code (it's very clever).
>
> [0] https://www.coreboot.org/scan-build/

I could not see a commit hash in scan-build output, I assume it runs on master HEAD always.

But we shall see the results once we submit this, and find remaining redundant NULL checks then. I fixed the ones easily discovered with grep.