Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )
Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/chip.h... PS2, Line 48: privacy
If we decide to go with this name, I think we should have a comment block explaining what this is us […]
Done
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 13: /* : * Return false if reset GPIO is not provided. : */
Comment needs update. Or we can probably drop it since it isn't really very helpful.
Done
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 60:
I think it would be safer to set reset_index and privacy_index here instead of expecting the same or […]
Done
https://review.coreboot.org/c/coreboot/+/46961/2/src/drivers/usb/acpi/usb_ac... PS2, Line 70: privacy
Do we have the liberty to choose the gpio name string that the driver uses? I would prefer using "ir […]
I think I prefer the privacy-gpio name. It shows the function of the pin and also allows device to have privacy and irq pins.