Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )
Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: Note: There is currently no mainboard in tree using this super I/O.
If you are going to use this code in the future, please mention it in the commit message
I don't. I deal with Asus boards with few exceptions and they don't use Fintek. grep really shows no reference to this device in the tree. Had I been more aggressive I'd propose dropping this outright, but I'll defer to others.
https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: super
Capitalize: Super
Done