Change in coreboot[master]: superio/fintek/f81216h: Rename pnp_enter_conf_state()

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Keith Hui (Code Review)

2 May 2020 2 May '20

2:48 a.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................

superio/fintek/f81216h: Rename pnp_enter_conf_state()

This one does require a version with non-standard signature. Rename to avoid conflict with upcoming standardization.

Note: There is currently no mainboard in tree using this super I/O.

Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Signed-off-by: Keith Hui buurin@gmail.com --- M src/superio/fintek/f81216h/early_serial.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40967/1

diff --git a/src/superio/fintek/f81216h/early_serial.c b/src/superio/fintek/f81216h/early_serial.c index d2fa0fe..d97dd86 100644 --- a/src/superio/fintek/f81216h/early_serial.c +++ b/src/superio/fintek/f81216h/early_serial.c @@ -9,14 +9,14 @@

#define FINTEK_EXIT_KEY 0xAA

-static void pnp_enter_conf_state(pnp_devfn_t dev, u8 f81216h_entry_key) +static void f81216h_pnp_enter_conf_state(pnp_devfn_t dev, u8 f81216h_entry_key) { u16 port = dev >> 8; outb(f81216h_entry_key, port); outb(f81216h_entry_key, port); }

-static void pnp_exit_conf_state(pnp_devfn_t dev) +void pnp_exit_conf_state(pnp_devfn_t dev) { u16 port = dev >> 8; outb(FINTEK_EXIT_KEY, port); @@ -43,7 +43,7 @@ key = 0x77; /* try the hw default */ break; } - pnp_enter_conf_state(dev, key); + f81216h_pnp_enter_conf_state(dev, key); pnp_set_logical_device(dev); pnp_set_enable(dev, 0); pnp_set_iobase(dev, PNP_IDX_IO0, iobase);

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Angel Pons (Code Review)

2 May 2 May

4:09 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: Note: There is currently no mainboard in tree using this super I/O. If you are going to use this code in the future, please mention it in the commit message

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: super Capitalize: Super

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 02 May 2020 16:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Keith Hui (Code Review)

5:58 p.m.

Hello build bot (Jenkins), Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40967

to look at the new patch set (#2).

Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................

superio/fintek/f81216h: Rename pnp_enter_conf_state()

This one does require a version with non-standard signature. Rename to avoid conflict with upcoming standardization.

Note: There is currently no mainboard in tree using this Super I/O.

Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Signed-off-by: Keith Hui buurin@gmail.com --- M src/superio/fintek/f81216h/early_serial.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40967/2

Keith Hui (Code Review)

6:01 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: Note: There is currently no mainboard in tree using this super I/O.

...

If you are going to use this code in the future, please mention it in the commit message

I don't. I deal with Asus boards with few exceptions and they don't use Fintek. grep really shows no reference to this device in the tree. Had I been more aggressive I'd propose dropping this outright, but I'll defer to others.

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: super

...

Capitalize: Super

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 02 May 2020 18:01:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

7:08 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Rename pnp_enter_conf_state() ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: Note: There is currently no mainboard in tree using this super I/O.

...

I don't. I deal with Asus boards with few exceptions and they don't use Fintek. […]

If it's unused, we can drop it altogether. It's not being build-tested

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 02 May 2020 19:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

11:37 p.m.

New subject: Change in coreboot[master]: superio/fintek/f81216h: Drop support

Hello build bot (Jenkins), Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40967

to look at the new patch set (#3).

Change subject: superio/fintek/f81216h: Drop support ......................................................................

superio/fintek/f81216h: Drop support

No mainboard use this anymore.

Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Signed-off-by: Keith Hui buurin@gmail.com --- D src/superio/fintek/f81216h/Kconfig D src/superio/fintek/f81216h/Makefile.inc D src/superio/fintek/f81216h/chip.h D src/superio/fintek/f81216h/early_serial.c D src/superio/fintek/f81216h/f81216h.h D src/superio/fintek/f81216h/superio.c 6 files changed, 0 insertions(+), 216 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40967/3

Angel Pons (Code Review)

3 May 3 May

2:28 a.m.

New subject: Change in coreboot[master]: superio/fintek/f81216h: Drop support

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Drop support ......................................................................

Patch Set 3: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/1//COMMIT_MSG@12 PS1, Line 12: Note: There is currently no mainboard in tree using this super I/O.

...

If it's unused, we can drop it altogether. […]

Ack

https://review.coreboot.org/c/coreboot/+/40967/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/3//COMMIT_MSG@9 PS3, Line 9: mainboard plural: mainboards

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 03 May 2020 02:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

4 May 4 May

11:32 p.m.

New subject: Change in coreboot[master]: superio/fintek/f81216h: Drop support

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40967

to look at the new patch set (#4).

Change subject: superio/fintek/f81216h: Drop support ......................................................................

superio/fintek/f81216h: Drop support

No mainboards use this anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40967/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Keith Hui (Code Review)

11:32 p.m.

New subject: Change in coreboot[master]: superio/fintek/f81216h: Drop support

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Drop support ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40967/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40967/3//COMMIT_MSG@9 PS3, Line 9: mainboard

...

plural: mainboards

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 May 2020 23:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5 May 5 May

1 p.m.

New subject: Change in coreboot[master]: superio/fintek/f81216h: Drop support

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40967 )

Change subject: superio/fintek/f81216h: Drop support ......................................................................

superio/fintek/f81216h: Drop support

No mainboards use this anymore.

Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40967 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- D src/superio/fintek/f81216h/Kconfig D src/superio/fintek/f81216h/Makefile.inc D src/superio/fintek/f81216h/chip.h D src/superio/fintek/f81216h/early_serial.c D src/superio/fintek/f81216h/f81216h.h D src/superio/fintek/f81216h/superio.c 6 files changed, 0 insertions(+), 216 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/superio/fintek/f81216h/Kconfig b/src/superio/fintek/f81216h/Kconfig deleted file mode 100644 index 17da818..0000000 --- a/src/superio/fintek/f81216h/Kconfig +++ /dev/null @@ -1,6 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -# This file is part of the coreboot project. - -config SUPERIO_FINTEK_F81216H - bool -# N.B. 'special romstage' diff --git a/src/superio/fintek/f81216h/Makefile.inc b/src/superio/fintek/f81216h/Makefile.inc deleted file mode 100644 index 6dd48a1..0000000 --- a/src/superio/fintek/f81216h/Makefile.inc +++ /dev/null @@ -1,6 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-or-later -# This file is part of the coreboot project. - -bootblock-$(CONFIG_SUPERIO_FINTEK_F81216H) += early_serial.c -romstage-$(CONFIG_SUPERIO_FINTEK_F81216H) += early_serial.c -ramstage-$(CONFIG_SUPERIO_FINTEK_F81216H) += superio.c diff --git a/src/superio/fintek/f81216h/chip.h b/src/superio/fintek/f81216h/chip.h deleted file mode 100644 index f5f7575..0000000 --- a/src/superio/fintek/f81216h/chip.h +++ /dev/null @@ -1,23 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* This file is part of the coreboot project. */ - -#ifndef SUPERIO_FINTEK_F81216H_CHIP_H -#define SUPERIO_FINTEK_F81216H_CHIP_H - -#include <stdint.h> - -/* Member variables are defined in devicetree.cb. */ -struct superio_fintek_f81216h_config { - /** - * KEY1 KEY0 Enter key - * 0 0 0x77 (default) - * 0 1 0xA0 - * 1 0 0x87 - * 1 1 0x67 - * - * See page 17 of data sheet. - */ - uint8_t conf_key_mode; -}; - -#endif /* SUPERIO_FINTEK_F81216H_CHIP_H */ diff --git a/src/superio/fintek/f81216h/early_serial.c b/src/superio/fintek/f81216h/early_serial.c deleted file mode 100644 index d2fa0fe..0000000 --- a/src/superio/fintek/f81216h/early_serial.c +++ /dev/null @@ -1,52 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* This file is part of the coreboot project. */ - -#include <arch/io.h> -#include <device/pnp_ops.h> -#include <device/pnp.h> -#include <stdint.h> -#include "f81216h.h" - -#define FINTEK_EXIT_KEY 0xAA - -static void pnp_enter_conf_state(pnp_devfn_t dev, u8 f81216h_entry_key) -{ - u16 port = dev >> 8; - outb(f81216h_entry_key, port); - outb(f81216h_entry_key, port); -} - -static void pnp_exit_conf_state(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - outb(FINTEK_EXIT_KEY, port); -} - -/* Bring up early serial debugging output before the RAM is initialized. */ -void f81216h_enable_serial(pnp_devfn_t dev, u16 iobase, mode_key k) -{ - u8 key; - switch (k) { - case MODE_6767: - key = 0x67; - break; - case MODE_7777: - key = 0x77; - break; - case MODE_8787: - key = 0x87; - break; - case MODE_A0A0: - key = 0xA0; - break; - default: - key = 0x77; /* try the hw default */ - break; - } - pnp_enter_conf_state(dev, key); - pnp_set_logical_device(dev); - pnp_set_enable(dev, 0); - pnp_set_iobase(dev, PNP_IDX_IO0, iobase); - pnp_set_enable(dev, 1); - pnp_exit_conf_state(dev); -} diff --git a/src/superio/fintek/f81216h/f81216h.h b/src/superio/fintek/f81216h/f81216h.h deleted file mode 100644 index 0c8463e..0000000 --- a/src/superio/fintek/f81216h/f81216h.h +++ /dev/null @@ -1,31 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* This file is part of the coreboot project. */ - -#ifndef SUPERIO_FINTEK_F81216H_H -#define SUPERIO_FINTEK_F81216H_H - -#include <device/pnp_type.h> - -/* Logical Device Numbers (LDN). */ -#define F81216H_SP1 0x00 /* UART1 (+CIR mode) */ -#define F81216H_SP2 0x01 /* UART2 */ -#define F81216H_SP3 0x02 /* UART3 */ -#define F81216H_SP4 0x03 /* UART4 */ -#define F81216H_WDT 0x08 /* WDT */ - -/** - * The PNP config entry key is parameterised - * by two bits on this Super I/O with 0x77 as - * the default key. - * See page 17 of data sheet for details. - */ -typedef enum { - MODE_6767 = 0x67, - MODE_7777 = 0x77, - MODE_8787 = 0x87, - MODE_A0A0 = 0xA0, -} mode_key; - -void f81216h_enable_serial(pnp_devfn_t dev, u16 iobase, mode_key k); - -#endif /* SUPERIO_FINTEK_F81216H_H */ diff --git a/src/superio/fintek/f81216h/superio.c b/src/superio/fintek/f81216h/superio.c deleted file mode 100644 index 52eedd6..0000000 --- a/src/superio/fintek/f81216h/superio.c +++ /dev/null @@ -1,98 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* This file is part of the coreboot project. */ - -#include <arch/io.h> -#include <device/device.h> -#include <device/pnp.h> -#include <superio/conf_mode.h> -#include <console/console.h> - -#include "chip.h" -#include "f81216h.h" - - -static void pnp_enter_ext_func_mode(struct device *dev) -{ - const struct superio_fintek_f81216h_config *conf = dev->chip_info; - - u8 key; - - /** - * KEY1 KEY0 Enter key - * 0 0 0x77 (default) - * 0 1 0xA0 - * 1 0 0x87 - * 1 1 0x67 - * - * See page 17 of data sheet. - */ - switch (conf->conf_key_mode) { - case MODE_6767: - case MODE_7777: - case MODE_8787: - case MODE_A0A0: - key = conf->conf_key_mode; - break; - default: - printk(BIOS_WARNING, "Warning: Undefined F81216 unlock key assignment!\n"); - printk(BIOS_WARNING, "Setting conf_key_mode to default\n"); - key = MODE_7777; /* try the hw default */ - break; - } - - outb(key, dev->path.pnp.port); - outb(key, dev->path.pnp.port); -} - -static void pnp_exit_ext_func_mode(struct device *dev) -{ - outb(0xaa, dev->path.pnp.port); -} - -static const struct pnp_mode_ops pnp_conf_mode_ops = { - .enter_conf_mode = pnp_enter_ext_func_mode, - .exit_conf_mode = pnp_exit_ext_func_mode, -}; - - -static void f81216h_init(struct device *dev) -{ - if (!dev->enabled) - return; - - switch (dev->path.pnp.device) { - case F81216H_SP1: - case F81216H_SP2: - case F81216H_SP3: - case F81216H_SP4: - case F81216H_WDT: - break; - } -} - -static struct device_operations ops = { - .read_resources = pnp_read_resources, - .set_resources = pnp_set_resources, - .enable_resources = pnp_enable_resources, - .enable = pnp_alt_enable, - .init = f81216h_init, - .ops_pnp_mode = &pnp_conf_mode_ops, -}; - -static struct pnp_info pnp_dev_info[] = { - { NULL, F81216H_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, F81216H_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, F81216H_SP3, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, F81216H_SP4, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, F81216H_WDT, }, -}; - -static void enable_dev(struct device *dev) -{ - pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); -} - -struct chip_operations superio_fintek_f81216h_ops = { - CHIP_NAME("Fintek F81216H/D/DG/F/FG Super I/O") - .enable_dev = enable_dev -};

-- To view, visit https://review.coreboot.org/c/coreboot/+/40967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d58d73eca0be1f4daf9106a1258274486f803a5 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1476

days inactive

1479

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Keith Hui (Code Review)
Patrick Georgi (Code Review)