Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )
Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/variant.c:
https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede...
PS2, Line 14: filename
Yes.
I think default SAR table is not added into CBFS yet. In the absence of wifi_sar_defaults.hex in CBFS, the ACPI SAR table is not emitted. So it shouldn't be a problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I710240f5e965f523fb8ac55a67880e1cbf9abd48
Gerrit-Change-Number: 45298
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Sep 2020 17:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment