Change in coreboot[master]: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer

The debug statement to print WiFi SAR file can potentially have a NULL
pointer. Also the debug statement does not much value. Hence remove the
debug statement.

BUG=b:165613510
TEST=Build and boot the drawcia board to OS.

Change-Id: I710240f5e965f523fb8ac55a67880e1cbf9abd48
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45298/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c
index 5c969a6..88e9de7 100644
--- a/src/mainboard/google/dedede/variants/drawcia/variant.c
+++ b/src/mainboard/google/dedede/variants/drawcia/variant.c
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <bootstate.h>
-#include <console/console.h>
 #include <fw_config.h>
 #include <sar.h>

@@ -12,6 +11,5 @@
    if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
    	filename = "wifi_sar-drawcia.hex";

-	printk(BIOS_INFO, "SAR file name: %s\n", filename);
    return filename;
 }

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer

The debug statement to print WiFi SAR file can potentially have a NULL
pointer. Also the debug statement does not add much value. Hence remove the
debug statement.

BUG=b:165613510
TEST=Build and boot the drawcia board to OS.

Change-Id: I710240f5e965f523fb8ac55a67880e1cbf9abd48
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45298/2

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
PS2, Line 14: filename
What filename is used in case on No tablet mode? Is it just the default wifi_sar_defaults.hex?

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
PS2, Line 14: filename
> What filename is used in case on No tablet mode? Is it just the default wifi_sar_defaults. […]

Yes.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
PS2, Line 14: filename
> Yes.

I think default SAR table is not added into CBFS yet. In the absence of wifi_sar_defaults.hex in CBFS, the ACPI SAR table is not emitted. So it shouldn't be a problem.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/45298/2/src/mainboard/google/dedede... 
PS2, Line 14: filename
> I think default SAR table is not added into CBFS yet. In the absence of wifi_sar_defaults. […]

SG. It is just a little odd that we use wifi_sar_defaults.hex which gets added very differently to CBFS than the other SAR files.

Anyways, we have the boxster + SAR file integration happening soon. So, we will have to revisit this anyways.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

Patch Set 2:

Submitting it now to prevent the regression from propagating soon.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45298 )

Change subject: mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer
......................................................................

mb/google/dedede/var/drawcia: Remove debug statement with NULL pointer

The debug statement to print WiFi SAR file can potentially have a NULL
pointer. Also the debug statement does not add much value. Hence remove the
debug statement.

BUG=b:165613510
TEST=Build and boot the drawcia board to OS.

Change-Id: I710240f5e965f523fb8ac55a67880e1cbf9abd48
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45298
Tested-by: build bot (Jenkins) 
Reviewed-by: Justin TerAvest 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/dedede/variants/drawcia/variant.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c
index 5c969a6..88e9de7 100644
--- a/src/mainboard/google/dedede/variants/drawcia/variant.c
+++ b/src/mainboard/google/dedede/variants/drawcia/variant.c
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <bootstate.h>
-#include <console/console.h>
 #include <fw_config.h>
 #include <sar.h>

@@ -12,6 +11,5 @@
    if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
    	filename = "wifi_sar-drawcia.hex";

-	printk(BIOS_INFO, "SAR file name: %s\n", filename);
    return filename;
 }