Kevin OConnor has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32351 )
Change subject: SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ......................................................................
Patch Set 11:
There's three patches here. The third patch was sent to the seabios mailing list just yesterday - in general it looks fine and I'd be inclined to merge it into seabios.
As discussed in the past on the seabios mailing list, I don't agree with the first two patches. The first patch adds significant complexity to the boot menu system for an extremely rare situation (more than about 30 bootable items). Also, since that patch was originally sent, seabios now natively supports more than 10 bootable items. There was a review and discussion on the second patch on the seabios mailing list, but not all the review comments were addressed.
-Kevin