There's three patches here. The third patch was sent to the seabios mailing list just yesterday - in general it looks fine and I'd be inclined to merge it into seabios.

As discussed in the past on the seabios mailing list, I don't agree with the first two patches. The first patch adds significant complexity to the boot menu system for an extremely rare situation (more than about 30 bootable items). Also, since that patch was originally sent, seabios now natively supports more than 10 bootable items. There was a review and discussion on the second patch on the seabios mailing list, but not all the review comments were addressed.


View Change

To view, visit change 32351. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf4efba31091a8678b51c2f6541d440c5cc6d37d
Gerrit-Change-Number: 32351
Gerrit-PatchSet: 11
Gerrit-Owner: Mike Banon <>
Gerrit-Reviewer: Kevin OConnor <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Mike Banon <>
Gerrit-Reviewer: Stefan Reinauer <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Fri, 04 Dec 2020 20:24:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment