Attention is currently required from: Angel Pons, David Hendricks, Evgeny Zinoviev, Martin L Roth, Paul Menzel.
Felix Singer has posted comments on this change by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/32673?usp=email )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 57:
(9 comments)
File src/mainboard/apple/macbookpro10_1/Kconfig:
PS52:
Should have a license header
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0d62832f_42eb6259?usp... : PS52, Line 22: config MAINBOARD_DIR : string : default "apple/macbookpro10_1" : : config MAINBOARD_PART_NUMBER : string : default "MacBookPro10,1" : : config VGA_BIOS_ID : string : default "8086,0166" : : config DRAM_RESET_GATE_GPIO : int : default 28 : : config USBDEBUG_HCD_INDEX : int : default 0
Types are redundant: […]
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/0a3ba42b_437a847e?usp... : PS52, Line 42: config MAX_CPUS : int : default 8
Matches default value, please remove
Done
File src/mainboard/apple/macbookpro10_1/Kconfig.name:
PS52:
Should have a license header
Done
File src/mainboard/apple/macbookpro10_1/acpi/superio.asl:
PS52:
Should be licensed as CC-PDDC instead
Done
File src/mainboard/apple/macbookpro10_1/devicetree.cb:
PS52:
Should have a license header
Done
https://review.coreboot.org/c/coreboot/+/32673/comment/61e7ef33_f5810a1b?usp... : PS52, Line 16: device cpu_cluster 0 on : chip cpu/intel/model_206ax : device lapic 0 on end : device lapic 0xacac off end : end : end : : device domain 0 on : subsystemid 0x106b 0x00f7 inherit : device pci 00.0 on end # Host bridge : device pci 01.0 on end # PCIe Bridge for discrete graphics : device pci 01.2 on end : device pci 01.1 on end : device pci 02.0 on end # Internal graphics VGA controller : chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH : register "gen1_dec" = "0x000c0681" : register "gen2_dec" = "0x000c1641" : register "gen3_dec" = "0x001c0301" : register "gen4_dec" = "0x00fc0701" : register "gpi7_routing" = "2" : register "pcie_port_coalesce" = "1" : register "sata_interface_speed_support" = "0x3" : register "sata_port_map" = "0x1" : register "spi_lvscc" = "0x0" : register "spi_uvscc" = "0x2005" : register "superspeed_capable_ports" = "0x0000000f" : register "xhci_overcurrent_mapping" = "0x08040201" : register "xhci_switchable_ports" = "0x0000000f" : device pci 14.0 on end # USB 3.0 Controller : device pci 16.0 on end # Management Engine Interface 1 : device pci 16.1 off end # Management Engine Interface 2 : device pci 16.2 off end # Management Engine IDE-R : device pci 16.3 off end # Management Engine KT : device pci 19.0 off end # Intel Gigabit Ethernet : device pci 1a.0 on end # USB2 EHCI #2 : device pci 1b.0 on end # HD Audio controller : device pci 1c.0 on end # PCIe Port #1 : device pci 1c.1 on end # PCIe Port #2 : device pci 1c.2 off end # PCIe Port #3 : device pci 1c.3 off end # PCIe Port #4 : device pci 1c.4 off end # PCIe Port #5 : device pci 1c.5 off end # PCIe Port #6 : device pci 1c.6 off end # PCIe Port #7 : device pci 1c.7 off end # PCIe Port #8 : device pci 1d.0 on end # USB2 EHCI #1 : device pci 1e.0 off end # PCI bridge : device pci 1f.0 on # LPC bridge : chip drivers/apple/hybrid_graphics : device pnp ff.f on end # dummy : register "gmux_indexed" = "1" : end : end : device pci 1f.2 on end # SATA Controller 1 : device pci 1f.3 on end # SMBus : device pci 1f.5 off end # SATA Controller 2 : device pci 1f.6 off end # Thermal : end : end
Should be updated to make use of chipset devicetree aliases.
Done
File src/mainboard/apple/macbookpro10_1/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/32673/comment/2c6028dd_0a58975e?usp... : PS52, Line 10: // OEM revision
Please remove this comment, it's autoport copypasta (which CB:82401 finally got rid of)
Done
File src/mainboard/apple/macbookpro10_1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/32673/comment/b0b45a88_dc8730b8?usp... : PS52, Line 8:
nit: drop blank line?
Done