Attention is currently required from: Felix Singer, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42460 )
Change subject: treewide: Configure PCI Bus Master based on Kconfig option
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
Shouldn't this be done by whoever needs to use the device, though?
I believe we claim to offer PIC i8259 interrupt compatibility on entry to payload, thus a payload can be completely unaware of LAPICs and IOAPICs. And there is no standard way to determine what PCI device provides IOAPIC.
It is possibly only an IRQ0 timer routing entry that would be affected from the disabled bus-mastering. I have CB:55287 and trying to figure out there what to test.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25565315a5ddf8d53097ac4cb4884ecebcc9c0a9
Gerrit-Change-Number: 42460
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 17 Jun 2021 03:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment