Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39172 )
Change subject: screen fix ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please unselect `DRIVERS_PS2_KEYBOARD` for the tests below.
Please build the GRUB payload directly, and change the image creation `make default_payload.elf` to include `at_keyboard` in the GRUB core and not as a module.
Also, it’d be also good to know, if the PS/2 keyboard works in TianoCore and in libpayload based payloads like coreinfo.
So I cloned the repo you indicated me in /src, then I ran ./bootstrap, ./autogen.sh ./configure --with-platform=coreboot, make -j$(nproc) and make default_payload.elf and now I don't know what to do next because I guess I want to include at_keyboard in GRUB and then precise coreboot to use this payload, but I don't really know how to do these two things and don't want to mess things up. Could you please guide me though those two steps ?
I am sorry for missing your reply. First, I meant, to include `at_keyboard` as a module, so when loaded, the messages get logged. Second, move `at_keyboard` to `--install-modules`:
@COND_i386_coreboot_TRUE@@COND_real_platform_TRUE@ pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(FS_PAYLOAD_MODULES) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
to
@COND_i386_coreboot_TRUE@@COND_real_platform_TRUE@ pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='at_keyboard ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(FS_PAYLOAD_MODULES) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
Then in the GRUB config file:
terminal_output --append cbmemc set debug=atkeyb insmod at_keyboard