Patch Set 1:

Patch Set 1:

Please unselect `DRIVERS_PS2_KEYBOARD` for the tests below.

Please build the GRUB payload directly, and change the image creation `make default_payload.elf` to include `at_keyboard` in the GRUB core and not as a module.

Also, it’d be also good to know, if the PS/2 keyboard works in TianoCore and in libpayload based payloads like coreinfo.

So I cloned the repo you indicated me in /src, then I ran ./bootstrap, ./autogen.sh ./configure --with-platform=coreboot, make -j$(nproc) and make default_payload.elf and now I don't know what to do next because I guess I want to include at_keyboard in GRUB and then precise coreboot to use this payload, but I don't really know how to do these two things and don't want to mess things up. Could you please guide me though those two steps ?

I am sorry for missing your reply. First, I meant, to include `at_keyboard` as a module, so when loaded, the messages get logged. Second, move `at_keyboard` to `--install-modules`:

    @COND_i386_coreboot_TRUE@@COND_real_platform_TRUE@      pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(FS_PAYLOAD_MODULES) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg

to

    @COND_i386_coreboot_TRUE@@COND_real_platform_TRUE@      pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='at_keyboard ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(FS_PAYLOAD_MODULES) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg

Then in the GRUB config file:

    terminal_output --append cbmemc
set debug=atkeyb
insmod at_keyboard

View Change

To view, visit change 39172. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie68e77af77ccec83c29d3329ee9997b950b351f6
Gerrit-Change-Number: 39172
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002723
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Name of user not set #1002723
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Evgeny Zinoviev <me@ch1p.io>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 05 Sep 2020 09:09:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment