Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48512 )
Change subject: mb/google/volteer: Clean up romstage.c ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I think these were here so they got passed to FSP, there might be side effects of removing it.. I suspect the HDA one isn't a big deal since it was more of a problem with early boards when sound wasn't working at all, but I can't remember the details with the TBT UPDs..
The earlier change was done as part of b/167983038. The problem at that time was the TBT RPs were kept enabled in devicetree/overridetree even if the board wasn't using them. This caused the UPDs to be enabled as well. I think we need to ensure that the TBT RP and DMA device status in devicetree/overridetree is correct for all variants.
Good point, I'll go scrub the variants
voxel is the only one I know so far that's using usb4, and it's overridetree looks correct to me for all the tbt_* devices