Patch Set 1:

Patch Set 1:

Patch Set 1:

I think these were here so they got passed to FSP, there might be side effects of removing it.. I suspect the HDA one isn't a big deal since it was more of a problem with early boards when sound wasn't working at all, but I can't remember the details with the TBT UPDs..

The earlier change was done as part of b/167983038. The problem at that time was the TBT RPs were kept enabled in devicetree/overridetree even if the board wasn't using them. This caused the UPDs to be enabled as well. I think we need to ensure that the TBT RP and DMA device status in devicetree/overridetree is correct for all variants.

Good point, I'll go scrub the variants

voxel is the only one I know so far that's using usb4, and it's overridetree looks correct to me for all the tbt_* devices

View Change

To view, visit change 48512. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d067ff3d181b152c784634ff99202bb2b9202f7
Gerrit-Change-Number: 48512
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Comment-Date: Wed, 09 Dec 2020 23:41:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment